Tsystems 140 upgrade spring boot to 2.6.x #697
Conversation
|
There was a problem hiding this comment.
hey @tkuzynow, some comments, but not all tests visited.
Is the juni4 support removed? or do we agreed on upgrading from junit 4 to 5 in that? This is not a security issue I would say.
...va/de/caritas/cob/userservice/api/admin/service/consultant/ConsultantAdminFilterService.java
Show resolved
Hide resolved
| @@ -39,7 +39,9 @@ spring.liquibase.enabled=false | |||
| # Test datasource | |||
| spring.datasource.driver-class-name=org.h2.Driver | |||
| spring.datasource.url=jdbc:h2:mem:db;DB_CLOSE_DELAY=-1 | |||
| spring.sql.init.data-locations=classpath:database/UserServiceDatabase.sql | |||
There was a problem hiding this comment.
what is the difference here between
spring.sql.init.data-locations and spring.datasource.data?
There was a problem hiding this comment.
spring boot reworked properties, so the convention for some of them changed, now we need to use spring.sql.init.data-locations
There was a problem hiding this comment.
please take a look if we need the "old" spring.datasource.data property
.../java/de/caritas/cob/userservice/api/adapters/web/controller/AppointmentControllerE2EIT.java
Show resolved
Hide resolved
.../java/de/caritas/cob/userservice/api/adapters/web/controller/AppointmentControllerE2EIT.java
Show resolved
Hide resolved
| import org.springframework.web.util.UriTemplateHandler; | ||
|
|
||
| @SpringBootTest | ||
| @ExtendWith(OutputCaptureExtension.class) | ||
| @AutoConfigureMockMvc | ||
| // @AutoConfigureMockMvc |
There was a problem hiding this comment.
remove if not needed - is there a pattern? As I see correct many other tests still have this.
There was a problem hiding this comment.
there is no pattern -> it was required change for these tests to prevent execution on the mock Controller class. Without it all tests of this class were failing, they were not even reaching method body.
.../cob/userservice/api/admin/service/consultant/ConsultantAdminFilterServiceTenantAwareIT.java
Show resolved
Hide resolved
hey @patric-dosch-vi , I agree it's not required, this is side effect of using open rewrite plugin, which helps running this upgrade. I did not spend manual effort to migrate the tests from junit4 to junit5. |
Fixes #
Proposed Changes